Repository navigation
Split HLS and DASH into optional library modules - #415
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96c2672ee8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Test Results 1 390 files +16 1 417 suites +16 9m 22s ⏱️ -47s Results for commit c4c180f. ± Comparison against base commit 905e89a. This pull request removes 49 and adds 90 tests. Note that renamed tests count towards both. |
HLS and DASH were bundled into core and enabled for every SDK consumer. Move them into independently published
library:hlsandlibrary:dashmodules exposingHlsDownloadSourceandDashDownloadSource, with the same platform targets as core.Each module owns its parser and tests; core retains shared manifest fetching, URL/header handling and sequential transfer helpers. Apps and CLI register both sources with their existing HTTP engine, preserving their download behavior. SDK consumers opt into either source through
additionalSources.Capability reporting now advertises
hls.finiteanddash.finiteindependently and retainsmedia.finitewhen both are installed. The browser extension checks the matching capability. Formermediasource types route by URL for stored and pre-resolved tasks. URL validation errors identify the activehlsordashsource, including failures in original URLs, redirects and manifest references. Includes SDK documentation and Android CI coverage for both modules.Validation passed:
testDebugUnitTestplus core, torrent, HLS and DASH Android host tests. The capability test supplies an explicit temporary directory, so it does not require an Android application context.compilePublishedMetadata.git diff --check.The experimental desktop Native Image launcher was updated but was not built.
Publication verification also passed:
api,core,hlsanddashto an isolated local Maven repository, with signing disabled for this local check.publishAndReleaseToMavenCentraltask includes all HLS/DASH signing and publishing tasks. No artifacts were uploaded to Maven Central.