TPT-4656: Support NodeBalancer type and backend connectivity - #735
zliang-akamai wants to merge 3 commits into
Conversation
Expose type and backend_connectivity on NodeBalancer, document create kwargs, and cover IPv6/VPC backends in unit and integration tests.
There was a problem hiding this comment.
Pull request overview
Adds SDK support for NodeBalancer type and backend_connectivity by exposing them as read-only model properties, documenting the new create-time parameters, and extending tests/fixtures to cover IPv6 backend address formats and the new response fields.
Changes:
- Expose
NodeBalancer.typeandNodeBalancer.backend_connectivityas read-only properties and ensure they are omitted from PUT payloads. - Document
type,backend_connectivity,vpcs, andconfigson NodeBalancer creation, and update node address documentation to include IPv6 bracketed formats. - Expand unit/integration test coverage and fixtures to validate the new fields and IPv6 node address forwarding.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/objects/nodebalancers_test.py | Adds unit tests for IPv6 node creation, config rebuild with IPv6 nodes, and NodeBalancer type/backend_connectivity behavior. |
| test/unit/linode_client_test.py | Adds unit tests ensuring create() forwards type, backend_connectivity, configs node addresses, and vpcs. |
| test/integration/models/nodebalancer/test_nodebalancer.py | Updates integration create test to pass and assert type/backend_connectivity. |
| test/fixtures/nodebalancers.json | Extends list fixture data with type and backend_connectivity. |
| test/fixtures/nodebalancers_123456.json | Extends single NodeBalancer fixture with type and backend_connectivity. |
| test/fixtures/linode_instances_123_nodebalancers.json | Extends Linode->NodeBalancers fixture with type and backend_connectivity. |
| linode_api4/objects/nodebalancer.py | Updates node address docstring and adds NodeBalancer type/backend_connectivity properties. |
| linode_api4/groups/nodebalancer.py | Documents type, backend_connectivity, vpcs, and configs kwargs on NodeBalancer create. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are additive, consistent with existing patterns, and are backed by targeted unit/integration tests plus fixture updates.
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 0 new
- Review effort level: Lite
psnoch-akamai
left a comment
There was a problem hiding this comment.
LGTM. Do you want to merge it directly to dev or maybe proj branch?
📝 Description
Add SDK support for NodeBalancer
typeandbackend_connectivity.✔️ How to Test
Unit Testing
Integration Testing