Skip to content

Add additional missing icons sourced from Phosphor for the lightspeed collection - #26

Merged
brandonmarshal merged 2 commits into
developfrom
feature/ls-source-additional-lightspeed-icons
Sep 22, 2026
Merged

brandonmarshal merged 2 commits into
developfrom
feature/ls-source-additional-lightspeed-icons

Conversation

@brandonmarshal

Copy link
Copy Markdown
Collaborator

Summary

Adds 8 icons still missing from the lightspeed icon collection, found while cross-checking a set of design mockups against the existing assets/icons/lightspeed/ set. Each icon below was confirmed absent (or confirmed as a shape mismatch against an existing icon) before being sourced.

New icons

  • circle.svg — plain outline circle (radio-style indicator glyph)
  • coins.svg — stacked coin glyph; distinct from the existing stack.svg (a layered-squares glyph), which doesn't match a coin-stack shape
  • hard-drives.svg — stacked server/hard-drive rack glyph; distinct from the existing database.svg (a cylinder/drum glyph)
  • chart-bar.svg — ascending vertical bar chart; distinct from the existing chart-line-up.svg/trending-up.svg (diagonal line charts)
  • users-three.svg — three-person group glyph, for contexts needing a team/group icon distinct from the existing two-person users.svg
  • paper-plane-tilt.svg — tilted paper-plane/send glyph
  • git-fork.svg — single node branching into two, for phase/roadmap-style UI
  • chat-circle-dots.svg — circular chat bubble with a three-dot ellipsis; distinct from the existing chat.svg (a plain bubble silhouette, no dots)

All 8 are sourced from phosphor-icons/core's assets/regular set and verified byte-for-byte against the upstream Phosphor path data. Each file follows this collection's existing convention: viewBox="0 0 256 256", fill="currentColor" on <path> (not the <svg> root), matching assets/icons/lightspeed/README.md.

No PHP changes — LS_Plugin\Icons auto-registers every .svg dropped into assets/icons/lightspeed/ on init.

Scope and exclusions

This PR only adds the 8 SVG files above. It does not wire any icon into a theme template, pattern, or block instance — that consumption work is expected in a follow-up (ls-theme or similar), matching how prior icon-sourcing PRs (#21, #24) in this repo were scoped.

Test plan

  • npm run plugin:validate — passes
  • npm run security:scan — no new issues introduced by this branch (2 pre-existing warnings in taxonomy-filter/render.php, unrelated to this change)
  • xmllint --noout on all 8 new SVG files — valid XML
  • Each new SVG's <path d="..."> verified byte-for-byte against Phosphor's assets/regular source
  • Confirm all 8 new icons appear correctly in the block editor's icon picker on WordPress 7.1+

Icons
- Add circle.svg, coins.svg, hard-drives.svg, chart-bar.svg
- Add users-three.svg, paper-plane-tilt.svg
- Add git-fork.svg, chat-circle-dots.svg

Context
- Sourced from phosphor-icons/core regular weight
- Fills gaps found while cross-checking design mockups against the existing lightspeed icon set
@brandonmarshal brandonmarshal added area:block-editor Block/site editor work area:design-system Tokens/components guidelines priority:normal Default priority for most issues. status:needs-review Awaiting code review labels Sep 21, 2026
@brandonmarshal brandonmarshal self-assigned this Sep 21, 2026
Context
- Adds an Unreleased entry for PR #26's 8 new icons
- Follows this repo's Keep a Changelog convention

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@brandonmarshal

Copy link
Copy Markdown
Collaborator Author

Linear agent review completed — no actionable changes required. The PR is approved.

@brandonmarshal
brandonmarshal merged commit 9c7a55d into develop Sep 22, 2026
@brandonmarshal
brandonmarshal deleted the feature/ls-source-additional-lightspeed-icons branch September 22, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:block-editor Block/site editor work area:design-system Tokens/components guidelines priority:normal Default priority for most issues. status:needs-review Awaiting code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants