Repository navigation
Add additional missing icons sourced from Phosphor for the lightspeed collection - #26
Merged
brandonmarshal merged 2 commits intoSep 22, 2026
Conversation
Icons - Add circle.svg, coins.svg, hard-drives.svg, chart-bar.svg - Add users-three.svg, paper-plane-tilt.svg - Add git-fork.svg, chat-circle-dots.svg Context - Sourced from phosphor-icons/core regular weight - Fills gaps found while cross-checking design mockups against the existing lightspeed icon set
Context - Adds an Unreleased entry for PR #26's 8 new icons - Follows this repo's Keep a Changelog convention Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
Author
|
Linear agent review completed — no actionable changes required. The PR is approved. |
ZaredRogers
approved these changes
Sep 22, 2026
brandonmarshal
deleted the
feature/ls-source-additional-lightspeed-icons
branch
September 22, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 8 icons still missing from the
lightspeedicon collection, found while cross-checking a set of design mockups against the existingassets/icons/lightspeed/set. Each icon below was confirmed absent (or confirmed as a shape mismatch against an existing icon) before being sourced.New icons
circle.svg— plain outline circle (radio-style indicator glyph)coins.svg— stacked coin glyph; distinct from the existingstack.svg(a layered-squares glyph), which doesn't match a coin-stack shapehard-drives.svg— stacked server/hard-drive rack glyph; distinct from the existingdatabase.svg(a cylinder/drum glyph)chart-bar.svg— ascending vertical bar chart; distinct from the existingchart-line-up.svg/trending-up.svg(diagonal line charts)users-three.svg— three-person group glyph, for contexts needing a team/group icon distinct from the existing two-personusers.svgpaper-plane-tilt.svg— tilted paper-plane/send glyphgit-fork.svg— single node branching into two, for phase/roadmap-style UIchat-circle-dots.svg— circular chat bubble with a three-dot ellipsis; distinct from the existingchat.svg(a plain bubble silhouette, no dots)All 8 are sourced from
phosphor-icons/core'sassets/regularset and verified byte-for-byte against the upstream Phosphor path data. Each file follows this collection's existing convention:viewBox="0 0 256 256",fill="currentColor"on<path>(not the<svg>root), matchingassets/icons/lightspeed/README.md.No PHP changes —
LS_Plugin\Iconsauto-registers every.svgdropped intoassets/icons/lightspeed/oninit.Scope and exclusions
This PR only adds the 8 SVG files above. It does not wire any icon into a theme template, pattern, or block instance — that consumption work is expected in a follow-up (
ls-themeor similar), matching how prior icon-sourcing PRs (#21, #24) in this repo were scoped.Test plan
npm run plugin:validate— passesnpm run security:scan— no new issues introduced by this branch (2 pre-existing warnings intaxonomy-filter/render.php, unrelated to this change)xmllint --noouton all 8 new SVG files — valid XML<path d="...">verified byte-for-byte against Phosphor'sassets/regularsource