Replace PostgreSQL advisory locking with fenced leases - #1111
Draft
joostjager wants to merge 1 commit into
Draft
joostjager wants to merge 1 commit into
joostjager wants to merge 1 commit into
Conversation
Acquire a table-scoped lease before loading persisted state and validate and renew it atomically with each mutation. Renew idle leases in the background and permanently invalidate the store on detected lease loss, preserving panic behavior and the existing lock-contention error kind. Coordinate the one-way schema-v1 upgrade with the legacy advisory lock and commit the schema-v2 marker with the initial lease. Older releases then reject the upgraded store instead of bypassing lease fencing. Keep lease handling inside PostgresStore, with node lifecycle and recovery unchanged. Cover contention, migration, queued-write fencing, lease release, and panic propagation in the store tests.
|
👋 Hi! I see this is a draft PR. |
tnull
reviewed
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acquire a table-scoped lease before loading persisted state and validate and renew it atomically with each mutation. Renew idle leases in the background and permanently invalidate the store on detected lease loss, preserving panic behavior and the existing lock-contention error kind.
Coordinate the one-way schema-v1 upgrade with the legacy advisory lock and commit the schema-v2 marker with the initial lease. Older releases then reject the upgraded store instead of bypassing lease fencing.
Keep lease handling inside PostgresStore, with node lifecycle and recovery unchanged. Cover contention, migration, queued-write fencing, lease release, and panic propagation in the store tests.