Repository navigation
Conversation
- Lift a size-indexed TimeM cost to Mathlib IsBigO and IsTheta - Keep the import off TimeM.lean so other clients do not pull analysis
cdbattags
requested review from
SamuelSchlesinger,
arademaker,
chenson2018,
crei,
fmontesi and
sorrachai
as code owners
October 5, 2026 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mathlib's
Asymptotics.IsBigOandIsThetacompare two functions along a filter.TimeM.timeis one scalar, so a size-indexed computation does not fit that API by itself.This adds
TimeM.isBigOandTimeM.isThetainCslib/Algorithms/Lean/TimeM/Asymptotics.lean. They coerce(cost n).timetoℝand ask Mathlib whether that function ofnis big-O or big-Theta ofgatFilter.atTop. The module is separate fromTimeM.leanso existingTimeMclients do not import analysis.lake build Cslib.Algorithms.Lean.TimeM.Asymptoticssucceeded, andlake exe mk_allleft the new import inCslib.lean.Drafted with Grok 4.7, the 500k-context high-effort setting, in Cursor. I used it to read
TimeMand Mathlib'sAsymptotics.IsBigO/IsThetaand to write these two definitions. This repository has noLLM-generatedlabel; the disclosure above is the step CONTRIBUTING.md asks for, via the Mathlib policy.