make BrowserCode embeddable - #35
Open
rijulshrestha wants to merge 5 commits into
Open
rijulshrestha wants to merge 5 commits into
rijulshrestha wants to merge 5 commits into
Conversation
Deploying browsercode with
|
| Latest commit: |
0f4d6e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ef1d7a35.browsercode.pages.dev |
| Branch Preview URL: | https://embed-options.browsercode.pages.dev |
Contributor
Author
|
@GabrielaReyna I've created a separate docs folder containing some instructions on how to embed for now. Should we have this here in the repo, or just have it in the browserpod docs? |
rijulshrestha
marked this pull request as ready for review
September 14, 2026 13:14
GabrielaReyna
requested changes
Sep 17, 2026
GabrielaReyna
left a comment
Contributor
There was a problem hiding this comment.
Hi Rijul,
Thanks for working on this. I tested the embeddable components and they look great!
- Please address the opaque failure for agents when the headers are not set
- About your question on the documentation, please display it on the read me, or add a link to the md file from the readme. We will have a dedicated doc content in BrowserCode but this should do for this PR.
- On the message when the headers are not set, please add a link to "Learn more" that points to this repo.
- The 'Nothing to boot" message text is overflowing, please adjust it.
Contributor
There was a problem hiding this comment.
podBlocker() is not being imported in AgentShell as you do in IdeShell. Hence if the headers are not set correctly in the host site and an agent is embedded, it won't throw the intended message and the failure is opaque. Please correct this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
/embedthat composes the IDE or a CLI agent from the query string.agent/repo/frameworkpicks what boots,viewpicks the panes.crossOriginIsolatedcheck, so a host page missing the headers gets a clear message instead of an opaque boot failure.Embedders must send
COOP: same-originandCOEP: require-corpon their own page.