Conversation
|
Hi @JakeAmoah! 👋 Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
-Fixed the uppercase bug in "PASSWORD_VALIDATOR.py" where program doesn't check for uppercase letters even though it was part of the password requirements.
-Fixed a logical error in the README.md.
why
The bug made the program not to check for uppercase letters before validating. The logical error made the program seem as if it was to check for lowercase or uppercase before validating but the issue description suggests it should strictly check for uppercase not to treat it as an option if lowercase is entered.
How to test