Conversation
41tair
requested review from
JohnJyong,
QuantumGhost and
laipz8200
as code owners
September 18, 2026 05:52
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-09-18 06:09:45.447703396 +0000
+++ /tmp/pyrefly_pr.txt 2026-09-18 06:09:37.147660365 +0000
@@ -1809,29 +1809,29 @@
ERROR No attribute `MethodView` in module `builtins` [missing-attribute]
--> tests/unit_tests/controllers/common/test_fields.py:8:5
ERROR `in` is not supported between `Literal['Incorrect API key provided']` and `None` [not-iterable]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:1748:12
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:1684:12
ERROR `in` is not supported between `Literal['Start a new conversation']` and `None` [not-iterable]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:1780:12
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:1716:12
ERROR Argument `test_drain_streaming_generate_response_returns_on_message_end.ClosableResponse` is not assignable to parameter `response` with type `Generator[str] | RateLimitGenerator` in function `controllers.console.app.completion._drain_streaming_generate_response` [bad-argument-type]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:1903:69
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:1839:69
ERROR Argument `Iterator[str]` is not assignable to parameter `response` with type `Generator[str] | RateLimitGenerator` in function `controllers.console.app.completion._drain_streaming_generate_response` [bad-argument-type]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:1910:66
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:1846:66
ERROR Argument `Iterator[str]` is not assignable to parameter `response` with type `Generator[str] | RateLimitGenerator` in function `controllers.console.app.completion._drain_streaming_generate_response` [bad-argument-type]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:1916:66
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:1852:66
ERROR Object of class `object` has no attribute `data` [missing-attribute]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2338:50
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2274:50
ERROR Object of class `object` has no attribute `limit` [missing-attribute]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2339:30
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2275:30
ERROR Object of class `object` has no attribute `has_more` [missing-attribute]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2340:33
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2276:33
ERROR Object of class `object` has no attribute `data` [missing-attribute]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2383:50
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2319:50
ERROR Object of class `object` has no attribute `limit` [missing-attribute]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2384:30
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2320:30
ERROR Object of class `object` has no attribute `has_more` [missing-attribute]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2385:33
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2321:33
ERROR Argument `Literal['00000000-0000-0000-0000-000000000002']` is not assignable to parameter `message_id` with type `UUID` in function `controllers.console.app.message._get_message_suggested_questions` [bad-argument-type]
- --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2487:24
+ --> tests/unit_tests/controllers/console/agent/test_agent_controllers.py:2423:24
ERROR Object of class `int` has no attribute `lower` [missing-attribute]
--> tests/unit_tests/controllers/console/app/test_annotation_security.py:237:38
ERROR Object of class `int` has no attribute `lower` [missing-attribute]
@@ -1925,9 +1925,7 @@
ERROR Argument `scoped_session[flask_sqlalchemy.session.Session]` is not assignable to parameter `session` with type `sqlalchemy.orm.session.Session` in function `_add_binding` [bad-argument-type]
--> tests/unit_tests/controllers/console/datasets/test_data_source.py:85:28
ERROR Missing argument `name` in function `controllers.console.datasets.datasets.DatasetCreatePayload.__init__` [missing-argument]
- --> tests/unit_tests/controllers/console/datasets/test_datasets.py:602:49
-ERROR Object of class `NoneType` has no attribute `token` [missing-attribute]
- --> tests/unit_tests/controllers/console/datasets/test_datasets.py:1528:16
+ --> tests/unit_tests/controllers/console/datasets/test_datasets.py:605:49
ERROR Argument `Literal['custom']` is not assignable to parameter `mode` with type `ProcessRuleMode | SQLCoreOperations[ProcessRuleMode]` in function `models.dataset.DatasetProcessRule.__init__` [bad-argument-type]
--> tests/unit_tests/controllers/console/datasets/test_datasets_document.py:246:18
ERROR Argument `Literal['custom']` is not assignable to parameter `mode` with type `ProcessRuleMode | SQLCoreOperations[ProcessRuleMode]` in function `models.dataset.DatasetProcessRule.__init__` [bad-argument-type]
|
Contributor
Pyrefly Type Coverage
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #42489 +/- ##
==========================================
+ Coverage 87.40% 87.48% +0.08%
==========================================
Files 5463 5477 +14
Lines 315623 316985 +1362
Branches 63604 63514 -90
==========================================
+ Hits 275863 277316 +1453
+ Misses 34377 34287 -90
+ Partials 5383 5382 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
part of #39993
Screenshots
Checklist
make lint && make type-check(backend) andvp staged(frontend) to appease the lint gods