fix(ui-modal): keep content visible in safari after nested transitions - #2735
Open
joyenjoyer wants to merge 1 commit into
Open
joyenjoyer wants to merge 1 commit into
joyenjoyer wants to merge 1 commit into
Conversation
Safari sometimes doesn't repaint text in a tall, scrolling Modal body after a fade-in transition ends, e.g. with nested ToggleGroups, so the text stays invisible until selected. Make the Modal body a stacking context with `isolation: isolate` in v1 and v2, which avoids it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Contributor
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Baselines come from the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
isolation: isolateto the v1 and v2 ModalBody styles. Safari sometimes doesn't repaint text in a tall, scrolling Modal body after a fade-in transition ends (e.g. nested ToggleGroups), so the text stays invisible until selected.Test Plan
Repro snippet (docs site example)
Fixes INSTUI-5200
🤖 Generated with Claude Code