Conversation
|
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (7)badge-canvas.png — 1573 pixels differcheckboxgroup-canvas.png — 5379 pixels differcheckboxgroup-dark.png — 5249 pixels differcheckboxgroup-light.png — 4787 pixels differform-errors-canvas.png — 37228 pixels differform-errors-dark.png — 38391 pixels differform-errors-light.png — 37548 pixels differBaselines come from the |
| gridArea: 'controls', | ||
| // add a small margin between the message and the controls | ||
| ...(hasMessages && hasErrorMsgAndIsGroup && { marginTop: '0.375rem' }), | ||
| ...(hasMessages && hasMsgAndIsGroup && { marginTop: '0.375rem' }), |
There was a problem hiding this comment.
In index.tsx:100, hasMsgAndIsGroup = hasMessages && !!isGroup will now apply to all message types, causing the layout of the screenreader-only variant to shift.
The example below demonstrates this:
<Flex gap="large" alignItems="start">
<div>
<RadioInputGroup name="fruit1">
<RadioInput label="Apple" value="apple" />
</RadioInputGroup>
</div>
<div>
<RadioInputGroup
name="fruit2"
messages={[
{ type: 'screenreader-only', text: 'Pick one option' }
]}
>
<RadioInput label="Apple" value="apple" />
</RadioInputGroup>
</div>
</Flex>
suggestion:
...(hasNonEmptyMessages && hasMsgAndIsGroup && { marginTop: '0.375rem' }),
There was a problem hiding this comment.
good catch, I've fixed this case (also refactored the logic here, it was getting chaotic)
662b31e to
0da9daa
Compare
… (radio group, checkbox group, formFieldGroup) Before, a grouped field only moved its messages above the controls when one of them was an error. Hint and success messages stayed below. Now any message in a group renders above the controls, so the layout stays the same whatever the message type. Fixes INSTUI-5199 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0da9daa to
c91b5b7
Compare







Summary
FormFieldLayoutnow shows every message type above the controls in a group, not just errors. This coversRadioInputGroup,CheckboxGroup, andFormFieldGroup.Test Plan
RadioInputGroup,CheckboxGroup, andFormFieldGroup. Check that hint and success messages show above the controls in both stacked and inline layouts.TextInput) still show messages below the input.Fixes INSTUI-5199
🤖 Generated with Claude Code