fix(ui-progress): round all track corners in ProgressBar v2 - #2726
Merged
Merged
Conversation
The track set only borderTopLeftRadius and borderBottomLeftRadius, so its right corners stayed square inside the rounded trackLayout. Setting borderRadius rounds all four, and drops the physical left/right properties that rounded the wrong end under RTL. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
HerrTopi
requested review from
balzss,
joyenjoyer and
matyasf
and removed request for
balzss
September 23, 2026 09:39
Contributor
|
Contributor
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (4)progressbar-dark.png — 125 pixels differprogressbar-light.png — 127 pixels differtooltip-dark.png — 895 pixels differtooltip-light.png — 970 pixels differBaselines come from the |
matyasf
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
borderTopLeftRadius/borderBottomLeftRadiuswith a singleborderRadius, so all four corners round inside the roundedtrackLayout.Test Plan
light, anddarkthemes and canvas and its high contrast counterpart still has no rounded cornerssizevariants, and a0%and100%value, where the track andtrackValueradii interact.INSTUI-5194