Skip to content

feat(jobs): add database_fork job type - #200

Merged
hotdata-automation[bot] merged 1 commit into
mainfrom
openapi-update-35991775407
Sep 24, 2026
Merged

hotdata-automation[bot] merged 1 commit into
mainfrom
openapi-update-35991775407

Conversation

@hotdata-automation

Copy link
Copy Markdown
Contributor

Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www/pull/433

@hotdata-automation
hotdata-automation Bot requested a review from a team as a code owner September 24, 2026 11:14
@hotdata-automation
hotdata-automation Bot requested review from anoop-narang and removed request for a team September 24, 2026 11:14
@hotdata-automation
hotdata-automation Bot enabled auto-merge (squash) September 24, 2026 11:14
Comment thread CHANGELOG.md

### Changed

- feat(jobs): add database_fork job type

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add a ### Removed section with Breaking: entries for the public API that this regeneration deletes (not blocking).

The regeneration removes ConnectionsApi.purge_connection_cache, ConnectionsApi.purge_table_cache, and CreateConnectionRequest.skip_discovery. Callers of these symbols get AttributeError or a validation error after upgrade. The [0.11.0] section lists removals like these as Breaking: entries.

The single entry also names only database_fork. Consider adding the new surface too: get_database_lineage, lookup_database_by_name, set_*_constant_per_key, if_not_exists, vector_precision, and JobType.TABLE_CONSTANTS_UPDATE.



@validate_call
def purge_connection_cache(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Remove the purge_connection_cache call at tests/integration/test_connections_read.py:31-32, and update the module docstring there (not blocking).

This PR deletes purge_connection_cache. The test is skipped today, so CI stays green. When the seeded connection is restored and the skip is lifted, the test fails with AttributeError.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full diff was too large for the review prompt. The patch was fetched with gh pr diff and read, focusing on hotdata/api/, hotdata/models/, CHANGELOG.md, and the removed public methods. CI checks were still pending when this review was written.

@hotdata-automation
hotdata-automation Bot merged commit 95853cc into main Sep 24, 2026
5 checks passed
@hotdata-automation
hotdata-automation Bot deleted the openapi-update-35991775407 branch September 24, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants