ci: skip acceptance on Dependabot pull requests instead of failing them - #462
Merged
Merged
Conversation
GitHub does not pass repository secrets to a workflow Dependabot triggers, so every acceptance slice on a Dependabot PR failed in seconds on an empty test key -- "HOOKDECK_CLI_TESTING_API_KEY ... must be set" -- whatever the dependency. #459, #374 and #361 all went red this way. A check that is always red teaches people to ignore red. The caller job in test-acceptance.yml now skips when github.actor is dependabot[bot], matching how test.yml already treats build-linux. Merging a bump pushes to main as the merger, so the post-merge run has secrets and runs in full; dispatching the workflow on the Dependabot branch tests it before merging. The release gate calls acceptance.yml directly and is unaffected. The review skill records that skipped is not covered, and what covers it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012XtSQ2kfpcRXXqweskgXkH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub does not pass repository secrets to a workflow Dependabot triggers. Acceptance on every Dependabot PR therefore failed every slice in seconds on an empty test key —
HOOKDECK_CLI_TESTING_API_KEY … must be set— whatever the dependency. #459, #374 and #361 all went red this way.A check that is always red teaches people to ignore red.
Change
test-acceptance.yml: the caller job skips whengithub.actorisdependabot[bot]— the same conditiontest.ymlalready uses forbuild-linux.What still covers a dependency bump
main— merging pushes as the person who merged, so it has secrets and runs in full.ptytests, locally.acceptance.ymldirectly and is unaffected.Verified
🤖 Generated with Claude Code
https://claude.ai/code/session_012XtSQ2kfpcRXXqweskgXkH