Conversation
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:d02c6718dbca5109cc40a3fabefb6db5a0df8ab5f9f4999bd1c66cb3ec5d7c07"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-dina-add-test-to-highvalue-sections-aus-nz"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31829"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
deedeeh
force-pushed
the
dina/add-test-to-highvalue-sections-aus-nz
branch
from
September 30, 2026 11:12
adbbccb to
4077bb6
Compare
deedeeh
force-pushed
the
dina/add-test-to-highvalue-sections-aus-nz
branch
from
October 1, 2026 10:26
4077bb6 to
2ea417a
Compare
deedeeh
marked this pull request as ready for review
October 1, 2026 10:39
domlander
approved these changes
Oct 1, 2026
deedeeh
force-pushed
the
dina/add-test-to-highvalue-sections-aus-nz
branch
from
October 1, 2026 15:08
2ea417a to
5086af9
Compare
Contributor
Author
|
Created a new one #16837 due to Chromatic upgrade yesterday and that shows chromatic changes in my PR so to solve the issue is to create a new branch after the Chromatic upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds a new 0% test for new sections in Spacefinder
highValueSectionsin Australia and New Zealand regions.Commercial related PR guardian/commercial#2754
Why?
Introduce regionalisation to Spacefinder so we can test increasing ad ratio in the AUS and NZ regions
How has this change been tested?
Tested locally.