Skip to content

Add 0% test to highValueSections in AUS and NZ - #16817

Closed
deedeeh wants to merge 1 commit into
mainfrom
dina/add-test-to-highvalue-sections-aus-nz
Closed

deedeeh wants to merge 1 commit into
mainfrom
dina/add-test-to-highvalue-sections-aus-nz

Conversation

@deedeeh

@deedeeh deedeeh commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

What does this change?

This PR adds a new 0% test for new sections in Spacefinder highValueSections in Australia and New Zealand regions.

Commercial related PR guardian/commercial#2754

Why?

Introduce regionalisation to Spacefinder so we can test increasing ad ratio in the AUS and NZ regions

How has this change been tested?

Tested locally.

@deedeeh deedeeh self-assigned this Sep 30, 2026
@deedeeh deedeeh added Commercial 💰 maintenance Departmental tracking: maintenance work, not a fix or a feature labels Sep 30, 2026
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:d02c6718dbca5109cc40a3fabefb6db5a0df8ab5f9f4999bd1c66cb3ec5d7c07

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:d02c6718dbca5109cc40a3fabefb6db5a0df8ab5f9f4999bd1c66cb3ec5d7c07"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-dina-add-test-to-highvalue-sections-aus-nz"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31829"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-publish-image.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

@deedeeh
deedeeh force-pushed the dina/add-test-to-highvalue-sections-aus-nz branch from adbbccb to 4077bb6 Compare September 30, 2026 11:12
@deedeeh
deedeeh force-pushed the dina/add-test-to-highvalue-sections-aus-nz branch from 4077bb6 to 2ea417a Compare October 1, 2026 10:26
@deedeeh
deedeeh marked this pull request as ready for review October 1, 2026 10:39
@deedeeh
deedeeh requested a review from a team as a code owner October 1, 2026 10:39
@deedeeh
deedeeh requested a review from a team October 1, 2026 10:41
@deedeeh deedeeh added the run_chromatic Runs chromatic when label is applied label Oct 1, 2026
@deedeeh
deedeeh force-pushed the dina/add-test-to-highvalue-sections-aus-nz branch from 2ea417a to 5086af9 Compare October 1, 2026 15:08
@deedeeh

deedeeh commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Created a new one #16837 due to Chromatic upgrade yesterday and that shows chromatic changes in my PR so to solve the issue is to create a new branch after the Chromatic upgrade.

@deedeeh deedeeh closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Commercial 💰 maintenance Departmental tracking: maintenance work, not a fix or a feature run_chromatic Runs chromatic when label is applied

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants