Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures test coverage reporting for the google-crc32c package, setting a 100% coverage requirement, enabling unit tests in pure Python mode, and handling missing C extensions during testing. The review feedback suggests using lowercase "# pragma: no cover" comments to ensure coverage.py correctly excludes lines, enabling parallel coverage tracking in .coveragerc to prevent parallel test runs from overwriting coverage data, and updating the cover session in noxfile.py to combine these parallel coverage files before generating the report.
Contributor
|
It looks like the package is being passed over by the unit tests |
ohmayr
marked this pull request as draft
September 18, 2026 22:58
ohmayr
force-pushed
the
crc32c-add-nox-sessions
branch
from
September 19, 2026 04:56
2baf953 to
851f38f
Compare
Contributor
Author
|
kokoro:force-run |
ohmayr
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Remove outdated TODO comments and specify technical rationale for skipping core and prerelease dependency sessions.
ohmayr
marked this pull request as ready for review
September 19, 2026 06:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add unit and cover nox sessions and enforce 100% test coverage for google-crc32c
Fixes #17052