test: Support stateless GitHub App installation tokens - #4577
Open
sundaypaulfz3-cell wants to merge 1 commit into
Open
sundaypaulfz3-cell wants to merge 1 commit into
sundaypaulfz3-cell wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4577 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 197 197
Lines 18326 18326
=======================================
Hits 18068 18068
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add regression coverage for GitHub App stateless installation tokens.
GitHub's newer stateless installation tokens can be significantly longer than legacy installation tokens. These tests verify that go-github treats installation tokens as opaque strings rather than imposing fixed-length assumptions.
Changes
ghs_installation token from the installation-token API response.WithAuthTokenis sent unchanged as:Authorization: Bearer <token>.Testing
go test ./github— passedgit diff --check— passedgo test -v -race ./github— unable to run because Go's race detector is not supported on Android/ARM64.The current implementation already treats the token as an opaque string without a fixed-length validation constraint, so this change adds regression coverage for the required behavior.