Conversation
w-goog
added this pull request to stack #643
September 28, 2026 22:59
w-goog
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under theoretical data-race conditions, the EMM error handler could lose track of the error.
Issue 1: The completion handler could be evaluated before the value is returned, leading to confusing errors on the client. This could occur if the auth flow hasn't yet parsed the error and saved it within the block, which would lead to the error instead being interpreted as a non-EMM error.
Issue 2:
pendingDialoguestate hasn't been cleared due to a missing key window (highly unlikely).In both cases, sign in would still fail.