Conversation
mbg
force-pushed
the
mbg/start-proxy/deprecate-fallback
branch
from
October 6, 2026 15:56
362e7d4 to
cd87ccd
Compare
mbg
force-pushed
the
mbg/start-proxy/deprecate-fallback
branch
from
October 6, 2026 16:10
cd87ccd to
133ffeb
Compare
mbg
marked this pull request as ready for review
October 6, 2026 16:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
start-proxyAction currently uses its owngetReleaseByVersionfunction to get hold of the release that we expect to find the proxy assets at. That function has hard-codedownerandrepovalues for the defaultgithub/codeql-actionrepository. This repository may not be available in all environments. In such environments,getReleaseByVersionfails and we fall-back to the hard-coded release obtained fromgetFallbackUrlinstead.Broadly, this PR does the following:
getCodeQLActionRepositoryandgetCodeQLBundleDownloadURLare refactored out ofsetup-codeqlinto a newsetup/repositorymodule.getCodeQLAssetDownloadURL(renamed fromgetCodeQLBundleDownloadURL) in thestart-proxyaction to apply the same logic for finding a suitable release as used bysetup-codeql.getCodeQLBundleDownloadURLis essentially equivalent, except that it uses the linked version rather than a hard-coded one. We have been shipping proxy artifacts successfully with releases for a good while now, so the fallback shouldn't be needed anymore.There are some drive-by improvements to logging and assertions for sinon stubs.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist