Conversation
github-actions
Bot
changed the base branch from
main
to
nikpivkin/advisory-improvement-9617
September 19, 2026 12:21
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The advisory details and recommendation still incorrectly identify 1.21.1 as the first patched version.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Corrects the first patched gm version for GHSA-pjh3-jv7w-9jpr.
Changes:
- Changes the fixed version from 1.21.1 to 1.21.0.
- Updates the advisory modification timestamp.
| File | Description |
|---|---|
GHSA-pjh3-jv7w-9jpr.json |
Corrects the affected-version range. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
The first patched version should be 1.21.0, not 1.21.1.
The fix commit linked in the advisory is aheckmann/gm@5f5c774. It is the commit of tag 1.21.0, and tag 1.20.0 does not contain it. The project changelog marks 1.21.0 as "contains security fix" with the entry "gm.compare fails to escape arguments properly": https://github.com/aheckmann/gm/blob/master/History.md
Version 1.21.1 came out two hours later. It fixed a regression from the same change, where the gm binary path was hard coded, and it did not change the escaping.
The regression only breaks compare() when gm is not in /usr/bin or when ImageMagick is used. It is a functional bug and not a security issue, so 1.21.0 is not vulnerable.
The OSV export takes the fixed version from the first patched version, so version 1.21.0 is reported as vulnerable even though it has the fix.