fix(helm): support OCI references in HTTP repository indexes - #359
Open
abhinavgautam01 wants to merge 1 commit into
Open
abhinavgautam01 wants to merge 1 commit into
abhinavgautam01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320
Summary
Helm HTTP repositories can include
oci://chart references in theirindex.yaml. The proxy previously rejected these references, causing the entire index request to fail with a 502 response.Changes
Tests
Added coverage for mixed HTTP/OCI indexes, reference rewriting, invalid references, cooldown filtering, HTTP chart caching, OCI manifest and blob routing and server configuration wiring.
Local validation passed:
git diff --checkgo tool golangci-lint run ./...— 0 issuesgo vet ./...go build ./...go test -race ./...