Conversation
Contributor
size-limit report 📦
|
Removes the `traceLifecycle: 'static'` pin from `suites/hono-sdk`,
`suites/double-instrumentation` and `suites/public-api/metrics/server-address`,
and rewrites the Hono transaction assertions to span v2.
`double-instrumentation` and the metrics suite assert on an error event and on a
metric envelope, so only the pin goes. `double-instrumentation` swaps its
`ignore('transaction')` for `ignore('span')`, which is the envelope the
`http.server` span now races the error event with.
The Hono routes are parametrized patterns, so their segment names survive
streaming unchanged. What does change is the status: span v2 carries the coarse
`error` on the span and the specific `internal_error` in the
`sentry.status.message` attribute.
`suites/basic` keeps the static pin as the package's guard for the static trace
lifecycle. It is the smallest suite that still covers a plain worker fetch.
`suites/request-handler/subpath` also stays pinned, but for a different reason:
`wrapRequestHandler` from `@sentry/cloudflare/request` still sends a transaction
envelope with the pin removed, even with `traceLifecycle: 'stream'` passed
explicitly and with `cacheClient: false`. The client it builds does carry the
`SpanStreaming` integration, so the span reaches the isolation scope's client but
`getClient()` in `_onSpanEnded` does not see a streaming client. That is an SDK
question rather than a test one, so the suite is left as it was and gets its own
issue.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/cf-int-tests-request-handler-streaming
branch
from
September 19, 2026 15:46
876cda1 to
a608671
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the remaining request handler suites off the
traceLifecycle: 'static'pin:hono-sdk,double-instrumentationandpublic-api/metrics/server-address.double-instrumentationand the metrics suite assert on an error event and on a metric envelope, so only the pin goes.double-instrumentationswaps itsignore('transaction')forignore('span'), which is the envelope thehttp.serverspan now races the error event with.The Hono routes are parametrized patterns, so their segment names survive streaming unchanged. What does change is the status: span v2 carries the coarse
erroron the span and the specificinternal_errorin thesentry.status.messageattribute.Static trace lifecycle guard
suites/basickeeps the static pin as the package's guard. It is the smallest suite that still covers a plain worker fetch, so it is the cheapest one to keep on the old lifecycle.Suite left behind
suites/request-handler/subpathalso stays pinned, but not by choice. With the pin removed,wrapRequestHandlerfrom@sentry/cloudflare/requeststill sends a transaction envelope. That holds withtraceLifecycle: 'stream'passed explicitly and withcacheClient: false, and the transaction's ownsentry.sdk.integrationslistsSpanStreaming— so the client the event is processed by does have streaming on, whilegetClient()inside_onSpanEndeddoes not see a streaming client and falls through to_convertSpanToTransaction. Every other entry point in the package streams, and they differ only in which default integration set they inject, so this looks like a gap in the/requestentry rather than a test problem. It is tracked separately and the suite is left as it was.Fixes #24148
🤖 Generated with Claude Code