Conversation
Member
|
Please resolve the conflicts |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #1803. Tagged form widgets can now receive
alternateName(/TU) andstructParentthrough the public form methods. An explicitly suppliedfontSizealso applies when the field uses the default form font; omitting it preserves inherited appearance behavior.The structure reference captures the widget's page when it is created. Otherwise, adding a later page before finalizing the structure writes an OBJR pointing to that later page. Tests cover this delayed finalization together with nested field membership, distinct structure parents, Unicode/empty names, and explicit zero sizing.
Validation
yarn test --maxWorkers=4: 61 files, 536 tests passed. The unrestricted run timed out in four visual tests; the four-worker run kept the existing 8-second timeout.yarn lint,yarn build,yarn test:package, and formatting checks passed.ua1profile: 106 rules and 593 checks, zero failures. The same local workflow passed through a CommonJS esbuild bundle with registered standard-font metrics.Reproduction, source patch, sample PDF and detailed validation limits.
Checklist