feat(flow-php/types): remove structure allow_extra - #2660
Merged
Merged
Conversation
- type_structure() / StructureType take elements only, allowsExtra() removed - normalize() stops writing allow_extra, fromArray() ignores false and refuses true - Floe footer ignores unknown keys via array_intersect_key - flow_php extension drops allow_extra and its refusals - mago bridge always derives a sealed shape - pre-change Floe fixture proves 0.44 files still read in both engines
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2660 +/- ##
============================================
- Coverage 88.65% 88.65% -0.01%
+ Complexity 26551 26540 -11
============================================
Files 2044 2044
Lines 78145 78135 -10
============================================
- Hits 69281 69270 -11
- Misses 8864 8865 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
Fixed
Changed
flow-php/types- structure normalize() no longer writes allow_extra, fromArray() refuses allow_extra trueflow-php/etl- Floe footer ignores unknown keys without an open structureflow-php/mago-types-bridge- type_structure() always derives a sealed shapeRemoved
flow-php/types- type_structure() allow_extra argument and StructureType::allowsExtra()flow-php/etl- Floe refusal of structures allowing extra valuesflow-php/flow-php-ext- allow_extra schema field and its refusalsDeprecated
Security