Skip to content

H - #168

Open
mydickassbusiness wants to merge 7 commits into
firebase:update-cmake-3.22from
mydickassbusiness:main
Open

H#168
mydickassbusiness wants to merge 7 commits into
firebase:update-cmake-3.22from
mydickassbusiness:main

Conversation

@mydickassbusiness

Copy link
Copy Markdown

No description provided.

@google-cla

ghost commented Sep 19, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mydickassbusiness
mydickassbusiness changed the base branch from main to update-cmake-3.22 September 19, 2026 23:11

ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new file containing Firebase initialization code. The review feedback highlights a security concern regarding the hardcoding of sensitive Firebase configuration values, such as the API key and App ID, and recommends using environment variables instead to secure these credentials and improve configuration management across environments.

Comment thread npm install firebase
Comment on lines +9 to +17
const firebaseConfig = {
apiKey: "AIzaSyC9I_k156n49mwGRwMYZhWZW8yUcBSh4Ik",
authDomain: "autovending.firebaseapp.com",
projectId: "autovending",
storageBucket: "autovending.firebasestorage.app",
messagingSenderId: "8612541576",
appId: "1:8612541576:web:6709474bf3c0c30069db3d",
measurementId: "G-Y0YBZ9EBPQ"
};

ghost Sep 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

Hardcoding sensitive Firebase configuration values, especially the 'apiKey' and 'appId', directly in the source code is a security risk and makes configuration management difficult across different environments. It is highly recommended to use environment variables to store these values.

const firebaseConfig = {
  apiKey: process.env.REACT_APP_FIREBASE_API_KEY,
  authDomain: process.env.REACT_APP_FIREBASE_AUTH_DOMAIN,
  projectId: process.env.REACT_APP_FIREBASE_PROJECT_ID,
  storageBucket: process.env.REACT_APP_FIREBASE_STORAGE_BUCKET,
  messagingSenderId: process.env.REACT_APP_FIREBASE_MESSAGING_SENDER_ID,
  appId: process.env.REACT_APP_FIREBASE_APP_ID,
  measurementId: process.env.REACT_APP_FIREBASE_MEASUREMENT_ID
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants