Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds opt-in support for running bee through bee-runner (https://github.com/ethersphere/swarm-oci-registry). With
beeRunner.enabled: false, the default, the rendered chart does not change.When enabled, the bee container uses the
ghcr.io/ethersphere/bee-runnerimage. It runsbee-runner <options> -- start --config=.bee.yaml. The runner gets the latest release of its channel, checks the signature and sha256, and execs it. The chart has to set the command directly.beeCommandsetscommand:, which replaces the image's entrypoint. So changingimage.repositoryalone would skip the runner.Values
beeRunner.channel:stable,rcordev.beeRunner.registries: registry base URLs, tried in order. Empty means the public defaults for the channel. These are: the gateway with the channel's ENS name (stable and rc only), the gateway with the channel's feed manifest, thenhttps://registry.ethswarm.org.beeRunner.healthyAfter,maxCrashStarts: crash rollback.beeRunner.timeout,registryTimeout: time for one start, and time per registry.beeRunner.updateRestart: adds--update-restart, so bee exits in its rollout slot for a new release. This needs a bee with that option (feat: report newer signed releases and opt-in restart under bee-runner bee#5631). An older bee refuses the unknown flag.beeRunner.extraArgs: any other runner flag.The runner cache is
/home/bee/.bee/bin, on the data volume. It is not configurable on purpose. The record of what a node may not downgrade from lives there, and it must stay with the data.Testing
helm lintpasses.helm templatewith the defaults renders the same manifests as master (apart from the randomly generated password).beeRunner.enabled=truefor stable and dev, and withupdateRestart=true.Chart version 0.17.4 -> 0.17.5.