Enforce the line size limit on complete status and chunk-size lines - #517
Merged
Merged
Conversation
The limit was only checked while buffering an incomplete line, so a status line or chunk-size line larger than :max_header_list_size was accepted when it arrived complete in one message. A chunk-size line is now measured as a whole, size digits and chunk extensions included, both when it arrives in one message and when it is buffered.
Coverage Report for CI Build 185Coverage increased (+0.01%) to 89.571%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
馃挍 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:max_header_list_sizewas only checked for a status line or chunk-size line while it was buffered incomplete, so the same line arriving complete in one message wasn't limited. Both paths now apply the limit, and a chunk-size line is measured as a whole, size digits and chunk extensions included.The chunk-size and chunk-extension parsing now happens in one step instead of going through a separate
{:chunked, :metadata, size}state.