Conversation
Replace `div(month - 1, 3) + 1` with `(month * 5 + 14) >>> 4` for months 1..12 to avoid hardware integer division. Assisted-by: Antigravity:Gemini 3.8 Flash
Contributor
|
I'm a bit concerned we're over-optimizing here, the win is quite small and the code is more cryptic. |
Contributor
Author
On one hand I agree on the other hand I think the function itself is quite self contained and I believe that in the age of large language models it is easy to understand it once somebody wants to. In this module we already went into this direction however I am hundred percent okay with closing this pull request. |
Member
|
Yeah, for 1.05, not worth it :)Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Antigravity:Gemini 3.8 Flash
Minor speedup.
Bench:
Results: