Repository navigation
Implement javax.sql.DataSource - #895
Merged
Merged
Conversation
Contributor
Author
|
whoops, shouldn't have walked away so quickly |
Contributor
Author
|
I don't think there's much I can do about that one |
Member
Yep, there is an ongoing GH Actions outage, I'll restart the CI manually a bit later. |
staticlibs
approved these changes
Oct 6, 2026
staticlibs
left a comment
staticlibs
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
staticlibs
added a commit
that referenced
this pull request
Oct 6, 2026
This is a backport of the PR #895 to `v2.0-cyanoptera` branch. Co-Authored-By: Nnnes <N@nnn.es>
Member
|
A snapshot with this changes included can be used from this repo: <dependency>
<groupId>org.duckdb</groupId>
<artifactId>duckdb_jdbc</artifactId>
<version>2.0.0-dev-ccdc7fe</version>
</dependency><repository>
<id>duckdb</id>
<url>https://duckdb-staging.duckdb.org/duckdb/duckdb-java/maven/</url>
</repository> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #894.
Barebones implementation of
javax.sql.DataSourcewith a tiny test. Perhaps someday the unused username/password and login timeout methods can integrate with Quack. I'm not sure howunwrap()andisWrapperFor()are used normally, but the code is more or less functionally identical to several other JDBC implementations I looked at.