Skip to content

Let processor AttributeErrors surface - #154

Open
Bolt4243 wants to merge 1 commit into
dtcooper:masterfrom
Bolt4243:fix/processor-attributeerror-propagation
Open

Bolt4243 wants to merge 1 commit into
dtcooper:masterfrom
Bolt4243:fix/processor-attributeerror-propagation

Conversation

@Bolt4243

Copy link
Copy Markdown

Custom data processors can raise AttributeError from their own code. _run_processor currently catches that along with a missing hook, so parsing continues after hiding the processor failure.

Look up the optional processor first, then call it outside the exception handler. Missing hooks remain optional, while errors raised by existing processors now reach the caller.

Tests: full unittest suite, workflow flake8 checks, and coverage run with 93% total coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants