Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Comment on lines
+267
to
+271
| ! git merge-base --is-ancestor "${target_sha}" FETCH_HEAD || | ||
| [[ "$(git diff --name-only "${target_sha}" FETCH_HEAD)" != "${version_file}" ]] || | ||
| ! git show "${target_sha}:${version_file}" | | ||
| sed "s|<SqlClientNextVersion>${current_version}</SqlClientNextVersion>|<SqlClientNextVersion>${branch_version}</SqlClientNextVersion>|" | | ||
| cmp -s - <(git show "FETCH_HEAD:${version_file}"); then |
Comment on lines
+276
to
+279
| if [[ "${branch_version}" == "${next_version}" ]]; then | ||
| echo "::notice::Version-bump PR #${pr_number} already proposes ${next_version}." | ||
| exit 0 | ||
| fi |
paulmedynski
requested changes
Sep 29, 2026
Contributor
There was a problem hiding this comment.
This script could use some intent/explanatory comments throughout!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SqlClientNextVersioncurrently requires manual updates after releases or changes to the milestone plan. This adds milestone-closure and weekly reconciliation automation to propose version-bump PRs against the owning branch (mainorrelease/X.Y).The automation selects the next open milestone in the series, creates a patch milestone after a closure if needed, and skips stale events and legacy branches. Weekly runs can move
mainto the next unbranched series after a release branch is cut, or update an existing automation PR when a preview is discarded. It does not overwrite unrelated PR changes. No public API or runtime behavior changes.Generated PRs use
GITHUB_TOKEN, so ordinarypull_requestchecks do not automatically trigger; a follow-up commit using a non-default token is needed before merging.Issues
N/A
Testing
19 targeted Bats scenarios passed, covering branch routing, version selection, weekly reconciliation, duplicate/retry behavior, legacy branches, and failures. Bash syntax, workflow YAML parsing, and
git diff --checkpassed. No live milestone or PR was created as a test.Guidelines
Reviewed the repository contribution and versioning guidance; updated package-version instructions and script-test documentation.