You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Show outstanding feedback before code analysis, separating Copilot, other bots, and human reviewers. Reuse the sibling feedback skill's collection guidance when available from trusted policy.
Add concise finding examples and safeguards for permissions, automated publication, duplicate findings, and stale reviews.
Remove the redundant code-review prompt, link the skill from AGENTS.md, and correct unified reference-project guidance. No driver behavior changes or new automation.
Issues
N/A
Testing
Self-reviewed and addressed findings. Checked frontmatter, local links, reference links, anchors, whitespace, prompt removal, and feedback snapshot placement. Verified pinned upstream sources. Driver tests are not applicable to this documentation-only change.
The statement that all entries below are repository-relative is incorrect. For example, the table lists ConnectionPool/ChannelDbConnectionPool.cs, but the file is under src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/; several other entries are similarly abbreviated. This can send automated reviewers to nonexistent paths, so describe these as search starting points or expand them to full repository-relative paths.
The reason will be displayed to describe this comment to others. Learn more.
Docs/skill-only change. Two things:
Prompt says report the review as partial rather than using a terminal fallback, but SKILL.md says prefer gh for GitHub reads when available and documents an npx @microsoft/learn-cli fallback. Reconcile — as written an agent gets contradictory guidance on shell use.
Remove the redundant code-review prompt and direct reviewers to the skill. Add a read-only feedback snapshot with conditional reuse of the sibling feedback skill.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763
Update the API-changing prompts to match this unified reference path. implement-feature.prompt.md:29-33 and fix-bug.prompt.md:40 are still linked from AGENTS.md and direct agents to netcore/ref and netfx/ref, but those directories do not exist in this revision. Following either prompt will fail or recreate obsolete paths, so replace those legacy references with src/Microsoft.Data.SqlClient/ref/ and its conditional declarations.
Replace obsolete API reference paths in agent prompts
Fixed in c68baf0. Both feature and bug-fix prompts now use src/Microsoft.Data.SqlClient/ref/ and require matching conditional declarations for each affected framework.
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🟢 Approval recommended
The documentation is internally consistent, links resolve, prior concerns are addressed, and the unified reference guidance matches the current project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dotnet/runtime,dotnet/efcore, andmicrosoft/mssql-rs, with pinned sources.Issues
N/A
Testing
Self-reviewed and addressed findings. Checked frontmatter, local links, reference links, anchors, whitespace, prompt removal, and feedback snapshot placement. Verified pinned upstream sources. Driver tests are not applicable to this documentation-only change.
Guidelines