DCKA-5623: pin Node 24 via engines field and .nvmrc - #25
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dockscp
approved these changes
Sep 30, 2026
gasher
approved these changes
Sep 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #24 for DCKA-5623, addressing QA feedback.
Changes
.nvmrcpinning Node 24 for local developmentengines.node: 24.xtopackage.jsontest.yml) now reads the Node version from.nvmrcinstead of hardcoding it, so there is a single source of truthVercel
The app deploys to Vercel (per README). Vercel uses
engines.nodefrompackage.jsonin place of the project's Node.js version setting, so no dashboard change should be needed. Check the Node version in the next deployment's build logs to confirm.