feat(winrtble): allow overriding Coded PHY support - #493
Merged
Merged
Conversation
On some adapters that report Coded PHY support, scanning with UseCodedPhy enabled drops most 1M PHY advertisements: only frequent random-address beacons get through, while ordinary devices (named devices, peripherals with a public address advertising every ~2 s) are never reported, even right next to the PC. The same machine finds them with UseCodedPhy disabled. Add Adapter::set_coded_phy_supported on Windows to override the detected support. SetUseCodedPhy is now called on every scan, since the watcher is reused and the value can change between scans. Behavior is unchanged unless the override is used.
Contributor
|
Yup several of my users have also been complaining about this, you implemented exactly what I was planning on doing, so thanks a lot for that! I will see about getting a new version out with this ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some adapters that report Coded PHY support, scanning with UseCodedPhy enabled drops most 1M PHY advertisements: only frequent random-address beacons get through, while ordinary devices (named devices, peripherals with a public address advertising every ~2 s) are never reported, even right next to the PC. The same machine finds them with UseCodedPhy disabled.
Add Adapter::set_coded_phy_supported on Windows to override the detected support. SetUseCodedPhy is now called on every scan, since the watcher is reused and the value can change between scans. Behavior is unchanged unless the override is used.