fix: updateMany does not proceed past first page (#106) - #107
Merged
Merged
Conversation
nextPageState was read from data (always null for updateMany) instead of from status, where the API actually places it. This caused the pagination loop to terminate after the first 50 documents. - Read nextPageState from status via RESULT_NEXT_PAGE_STATE constant - Add unit tests (CollectionUpdateManyPaginationTest) covering the loop mechanics with a stubbed Collection subclass - Add integration test in AbstractCollectionIT that inserts 60 documents and verifies all are updated across two pages
There was a problem hiding this comment.
🟢 Approval recommended
The pagination fix is correctly implemented and covered by focused unit and integration tests.
Pull request overview
Fixes updateMany pagination by reading nextPageState from response status.
Changes:
- Adds the shared
nextPageStateresult constant. - Updates pagination logic and adds unit/integration coverage.
File summaries
| File | Description |
|---|---|
Collection.java |
Reads pagination state from status. |
AbstractCommandRunner.java |
Defines the result key. |
CollectionUpdateManyPaginationTest.java |
Tests multi-page behavior. |
AbstractCollectionIT.java |
Verifies 60 documents are updated. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Closes #106 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextPageState was read from data (always null for updateMany) instead of from status, where the API actually places it. This caused the pagination loop to terminate after the first 50 documents.