Skip to content

feat: add rsFIRO Ethereum token - #1444

Closed
reubenyap wants to merge 7 commits into
cypherstack:stagingfrom
reubenyap:codex/add-rsfiro-ethereum
Closed

reubenyap wants to merge 7 commits into
cypherstack:stagingfrom
reubenyap:codex/add-rsfiro-ethereum

Conversation

@reubenyap

@reubenyap reubenyap commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add rsFIRO to the default Ethereum token list using the official contract address and 8 decimals
  • let Campfire users add Firo and Ethereum wallets
  • limit Campfire Ethereum token choices to rsFIRO, USDC, and USDT while keeping Stack Wallet behavior unchanged
  • add missing default tokens to existing local token databases

Contract metadata: https://firo.org/2026/09/15/rsfiro-live.html

Testing

  • GitHub Actions test job passes
  • Dart formatting check passes
  • default-token allowlist test covers the Campfire Ethereum tokens

CI: https://github.com/cypherstack/stack_wallet/actions/runs/35188999250/job/105097180090

@julian-CStack

Copy link
Copy Markdown
Collaborator

We should avoid any more AppConfig.appName == "Campfire" checks when possible. The existing checks were absolutely required to be able to migrate correctly from the old Campfire. It would be better to make use of the appconfig stuff for this where we can have default token contracts lists as well as options to have/not have add/remove tokens.

The PR message mentions the contracts list check and mutation functionality does not change. This is false. Previously if a user removed a number of contract addresses while leaving at least one contract address then the code would leave that unchanged and with these changes it reinserts all default addresses back every time.

Closing this as it would be better to start fresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants