Conversation
Two robustness issues in the smoke test, both found with cppcheck/clang static analysis: 1. `test_deep_nesting()`-style depth tests `malloc()` the expression buffer and immediately memset/index it; on allocation failure this is a NULL dereference. Now records a failure via `lok(0)` and skips the case. 2. The equivalence test table calls `te_compile()` then dereferences the result right after `lok(ex)`; if compilation fails the test binary itself crashes instead of reporting a failed test. Now `continue`s after the failed `lok()` (still counted as a failure). Full suite still passes after the change: 10080/10080 under ASan+UBSan. Signed-off-by: warter666 <121139223+Warterkk@users.noreply.github.com>
Owner
|
Fixed. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two robustness issues in the smoke test, both found with cppcheck/clang static analysis:
test_deep_nesting()-style depth testsmalloc()the expression buffer and immediately memset/index it; on allocation failure this is a NULL dereference. Now records a failure vialok(0)and skips the case.te_compile()then dereferences the result right afterlok(ex); if compilation fails the test binary itself crashes instead of reporting a failed test. Nowcontinues after the failedlok()(still counted as a failure).Full suite still passes after the change: 10080/10080 under ASan+UBSan.
Signed-off-by: warter666 121139223+Warterkk@users.noreply.github.com