Read module descriptors newer than ASM supports - #239
Merged
Merged
Conversation
ClassReader throws IllegalArgumentException on a class file major version newer than the bundled ASM knows (e.g. 72 for JDK 28, #165). The module-info.class Module attribute hasn't changed since Java 9, so clamping the major version down to ASM's newest supported one is safe.
slachiewicz
marked this pull request as ready for review
September 25, 2026 23:40
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a toolchain
jdkHomeset,LocationManageralways parsesmodule-info.classwith ASM, which rejects class file versions it does not know: JDK 28 (major 72) fails on ASM 9.10.1 (see #165). The parser now lowers the major version to ASM's newest before reading; theModuleattribute has not changed since Java 9, so this stops every new JDK from waiting on an ASM release.This does not settle the Class File API question in #165.