fix: publish all subprojects to private mvn bucket - #564
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage ∅ diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-0.50%) Diff coverage ✅ ∅ diff coverage (50.00%) Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (68806c4) 1285 1048 81.56% Head commit (e1b8069) 1285 (+0) 1048 (+0) 81.56% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#564) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
No merge-blocking code issues were identified, and Codacy reports the PR is up to standards.
The acceptance criteria remain unverified because the review found no tests or successful end-to-end publish validation. In particular, the all-subprojects requirement depends on each project using Common.genericSettings.
About this PR
- Add automated or CI verification that each subproject resolves
publishToto the private Maven bucket and thatsbt +publishsucceeds for all subprojects.
Test suggestions
- Verify
codacyApiClient/publishTois configured for the private Maven repository. - Verify projects using
Common.genericSettings, including core, model, and toolRepositoryRemote, resolvepublishToto the private Maven repository. - Run
sbt +publishsuccessfully for all subprojects.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify `codacyApiClient/publishTo` is configured for the private Maven repository.
2. Verify projects using `Common.genericSettings`, including core, model, and toolRepositoryRemote, resolve `publishTo` to the private Maven repository.
3. Run `sbt +publish` successfully for all subprojects.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
codacyApiClient had no publishTo and the other subprojects still published to the sonatype staging dir, since privateMvnPublish only applied to the root project. Apply privateMvnPublish to every published subproject.
89edd02 to
e1b8069
Compare
Follow-up to #562.
sbt +publishfailed with(codacyApiClient / publishConfiguration) Repository for publishing is not specified.privateMvnPublishwas a bare setting inbuild.sbt, so it only applied to the root project.codacyApiClienthad nopublishTo, and core/model/toolRepositoryRemote still published to thesonatype-stagingdir.privateMvnPublishtoCommon.genericSettings(afterpublicMvnPublish, which is kept for itsDocker / publish := {})privateMvnPublishtocodacyApiClientVerified with
show <project>/publishTo; not verified with a real publish.