Skip to content

fix: publish all subprojects to private mvn bucket - #564

Merged
lolgab merged 2 commits into
masterfrom
fix-private-mvn-publish-all-projects
Oct 1, 2026
Merged

lolgab merged 2 commits into
masterfrom
fix-private-mvn-publish-all-projects

Conversation

@lolgab

@lolgab lolgab commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #562. sbt +publish failed with (codacyApiClient / publishConfiguration) Repository for publishing is not specified.

privateMvnPublish was a bare setting in build.sbt, so it only applied to the root project. codacyApiClient had no publishTo, and core/model/toolRepositoryRemote still published to the sonatype-staging dir.

  • add privateMvnPublish to Common.genericSettings (after publicMvnPublish, which is kept for its Docker / publish := {})
  • add privateMvnPublish to codacyApiClient

Verified with show <project>/publishTo; not verified with a real publish.

@codacy-production

codacy-production Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-0.50%)
Diff coverage ✅ ∅ diff coverage (50.00%)

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (68806c4) 1285 1048 81.56%
Head commit (e1b8069) 1285 (+0) 1048 (+0) 81.56% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#564) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

No merge-blocking code issues were identified, and Codacy reports the PR is up to standards.

The acceptance criteria remain unverified because the review found no tests or successful end-to-end publish validation. In particular, the all-subprojects requirement depends on each project using Common.genericSettings.

About this PR

  • Add automated or CI verification that each subproject resolves publishTo to the private Maven bucket and that sbt +publish succeeds for all subprojects.

Test suggestions

  • Verify codacyApiClient/publishTo is configured for the private Maven repository.
  • Verify projects using Common.genericSettings, including core, model, and toolRepositoryRemote, resolve publishTo to the private Maven repository.
  • Run sbt +publish successfully for all subprojects.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify `codacyApiClient/publishTo` is configured for the private Maven repository.
2. Verify projects using `Common.genericSettings`, including core, model, and toolRepositoryRemote, resolve `publishTo` to the private Maven repository.
3. Run `sbt +publish` successfully for all subprojects.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@lolgab
lolgab enabled auto-merge October 1, 2026 14:58
lolgab added 2 commits October 1, 2026 16:58
codacyApiClient had no publishTo and the other subprojects still
published to the sonatype staging dir, since privateMvnPublish only
applied to the root project. Apply privateMvnPublish to every
published subproject.
@lolgab
lolgab force-pushed the fix-private-mvn-publish-all-projects branch from 89edd02 to e1b8069 Compare October 1, 2026 14:58
@lolgab
lolgab merged commit 282cd36 into master Oct 1, 2026
8 checks passed
@lolgab
lolgab deleted the fix-private-mvn-publish-all-projects branch October 1, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants