Add explicit V10 function visibility - #5958
Draft
cloutiertyler wants to merge 2 commits into
Draft
cloutiertyler wants to merge 2 commits into
cloutiertyler wants to merge 2 commits into
Conversation
This reverts commit a140882.
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds explicit internal/private/public function declarations to V10 and all four module libraries. Preserves historical defaults while allowing explicit scheduled-function visibility; updates validation, migration diagnostics, and client generation, including lifecycle exclusion.
Split from #5892, which now contains only invocation authentication and its compatibility marker. This PR is deferred and is not a Container Hosting Stage 1 prerequisite. Companions: private #4008 and website #1366.
API and ABI breaking changes
Appends V10 visibility variants without changing existing tags. Modules using the new declarations require an updated host. No V11 ABI.
Rollback safety impact
Depends on #5892. Older hosts cannot load modules using the new declarations.
Expected complexity level and risk
4/5. Changes function admission, scheduled defaults, schema migration, and generated APIs.
Testing
The combined tree is identical to the previously tested V10 head. Existing visibility, compatibility, scheduling, module-library and code-generation tests are retained. CI reruns on this separate PR.