build(mosaic): externalize @floating-ui/react instead of bundling it - #9824
alexcarpenter wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 1ad371a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Description
Stacked on #9819.
@clerk/mosaicnow treats@floating-ui/reactas an external dependency instead of inlining it intodist/index.js. It was already listed independencies; the tsdown config moves it fromalwaysBundletoneverBundle, andcheck-bundle.mjsnow fails the build if the published JS stops importing@floating-ui/react.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change