Skip to content

build(mosaic): externalize @floating-ui/react instead of bundling it - #9824

Open
alexcarpenter wants to merge 2 commits into
carp/mosaic-headless-movefrom
carp/mosaic-floating-ui-dep
Open

alexcarpenter wants to merge 2 commits into
carp/mosaic-headless-movefrom
carp/mosaic-floating-ui-dep

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

Stacked on #9819.

@clerk/mosaic now treats @floating-ui/react as an external dependency instead of inlining it into dist/index.js. It was already listed in dependencies; the tsdown config moves it from alwaysBundle to neverBundle, and check-bundle.mjs now fails the build if the published JS stops importing @floating-ui/react.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
swingset Ready Ready Preview Sep 18, 2026 4:13pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
clerk-js-sandbox Skipped Skipped Sep 18, 2026 4:13pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1ad371a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/mosaic Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: ede73f0d-8abf-47f2-a750-bc34e82b6662

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant