feat(cli): use repository config for attestations - #3502
Open
waveywaves wants to merge 1 commit into
Open
waveywaves wants to merge 1 commit into
waveywaves wants to merge 1 commit into
Conversation
Use the existing Chainloop Trace config reader for attestation version loading and keep init flag validation running when the config is unavailable. Refs: chainloop-dev#3063 Assisted-by: pi Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Contributor
AI Session Checks — ⏭️ bypassed by labelAI Coding Session Check BypassedThis PR carries the Learn more about Chainloop Trace. Security Checks — ✅ 5 passing✅
|
| Status | Policy | Messages |
|---|---|---|
| ✅ Passed | secrets-detection |
- |
✅ sast-scan
| Status | Policy | Messages |
|---|---|---|
| ✅ Passed | owasp-top10-2025 |
- |
| ✅ Passed | sast |
- |
| ✅ Passed | cwe-top25 |
- |
| ✅ Passed | cwe-top26-40-cusp |
- |
✅ security-context — no advisories
Nothing this change touches has a recorded security-fix history.
View security context ↗ · Security context documentation ↗
⏭️ 3 scans not applied
| Scan | Reason |
|---|---|
vulnerability-scan |
no manifest/lockfile changed |
github-actions-scan |
no workflow files changed |
iac-scan |
no IaC files changed |
PR validation — ✅ 3 passing
| Status | Policy | Material | Messages |
|---|---|---|---|
| ✅ Passed | pr-min-approvals |
pr-info |
- |
| ✅ Passed | pr-description-required |
pr-info |
- |
| ✅ Passed | pr-user-story-linked |
pr-info |
- |
Powered by Chainloop and Chainloop Trace
10 tasks
waveywaves
marked this pull request as ready for review
October 1, 2026 13:23
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
migmartri
approved these changes
Oct 1, 2026
migmartri
left a comment
migmartri
left a comment
Member
There was a problem hiding this comment.
Awesome, added a comment about the location of the function. It looks strange that a general purpose function is in a specific trace package.
| // LoadChainloopYML loads the nearest .chainloop.yml (or .chainloop.yaml), | ||
| // walking from dir to the git repository root. In each directory, .yml takes | ||
| // precedence over .yaml. A config without projectName is still valid. | ||
| func LoadChainloopYML(dir string) (*ChainloopYML, string, error) { |
Member
There was a problem hiding this comment.
I'd personally would have put this function in cmd/config instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts the implementation of Spec 001: Project and Organization from
.chainloop.ymlin Attestations. It covers R-007 and R-008. The complete implementation is tracked in #3504.Summary
.chainloop.ymlover.chainloop.yaml, accepts files withoutprojectName, and returns the selected path (R-007).attestation initreadsprojectVersionthrough the shared reader and continues normal flag validation when the config is missing or cannot be read (R-008).Requirements covered
The remaining requirements and every implementation PR are tracked in #3504.
Refs #3063
AI assistance
pi helped to write this change. The commit carries an
Assisted-by: pitrailer.