Conversation
The data model section told contributors to create the versioned migration with make migration_new. That target stopped diffing the Ent schema in ef06a7c (chainloop-dev#557, March 2024), where it became atlas migrate new and the diff behaviour moved to migration_sync, which generate now depends on. Following the step as written produces an empty migration. Document the current procedure and note that a data backfill is a separate, hand-written migration. Assisted-by: Claude Code Signed-off-by: Tomasz Edward Posluszny <tom@devpeer.net>
Contributor
Security Checks — ✅ 8 passing✅
|
| Status | Policy | Messages |
|---|---|---|
| ✅ Passed | secrets-detection |
- |
✅ sast-scan
| Status | Policy | Messages |
|---|---|---|
| ✅ Passed | owasp-top10-2025 |
- |
| ✅ Passed | sast |
- |
| ✅ Passed | cwe-top25 |
- |
| ✅ Passed | cwe-top26-40-cusp |
- |
PR info
| Status | Policy | Messages |
|---|---|---|
| ✅ Passed | pr-min-approvals |
- |
| ✅ Passed | pr-description-required |
- |
| ✅ Passed | pr-user-story-linked |
- |
⏭️ 3 scans not applied
| Scan | Reason |
|---|---|
vulnerability-scan |
no manifest/lockfile changed |
github-actions-scan |
no workflow files changed |
iac-scan |
no IaC files changed |
View attestation ↗
View attestation ↗
Powered by Chainloop and Chainloop Trace
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
migmartri
approved these changes
Sep 20, 2026
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control plane README tells contributors to create the versioned migration for an Ent schema change with
make migration_new. That target stopped diffing the Ent schema in ef06a7c (#557, March 2024), when it becameatlas migrate newand the diff behaviour moved to the newmigration_synctarget, whichgeneratedepends on. Following the step as written produces an empty migration file. The sentence has also been truncated mid-way since #220, with an unclosed backtick.This documents the current procedure:
make -C app/controlplane generatewrites the migration viamigration_sync, and the rootmake generatedoes not. It also notes that a data backfill is a separate, hand-written migration, as in #2454.AI disclosure: this change was produced with AI assistance (Claude Code); the affected commit carries an
Assisted-bytrailer.