Link the tested remote-service samples from the external-service page - #34
Merged
Merged
Conversation
The page said, rightly, that nothing tested a remote service call and that its Northwind code was the shape rather than a measured recipe. cap2UI5/samples-stack now has that recipe: Z2UI5_CL_CAPS_APP_001 reads SAP S/4HANA's API_BUSINESS_PARTNER with cds.connect.to and cds.ql, runs against CAP's mock without the system, and is tested against that mock and through a real OData V2 request. Z2UI5_CL_CAPS_APP_002 does the same for a function module over RFC with @sap/cds-rfc. The warning becomes a pointer to the sample, and keeps saying that the Northwind code itself runs in no test. verify-refs reads the two sample names as framework classes because of their z2ui5_ prefix, so they go into .verify-refs-ignore with that reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TRkYvBYut1a1PjFYuUAcqj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
docs/examples/external-odata.md("Calling an External Service")Z2UI5_CL_CAPS_APP_001reads SAP S/4HANA'sAPI_BUSINESS_PARTNERwithcds.connect.toandcds.ql. It runs against CAP's mock when no system is configured, and its tests cover the mock and a real OData V2 request. The tip still says that no test runs the page's own Northwind code.Z2UI5_CL_CAPS_APP_002: a function module called over RFC with@sap/cds-rfc.docs/.verify-refs-ignorez2ui5_cl_caps_app_001andz2ui5_cl_caps_app_002under a new section, "apps of other repositories", with a reason on each entry. verify-refs treats anyz2ui5_name as a framework class. These two are apps registered withdefineAppin samples-stack, so they are not in the abap2UI5 source it checks.Check run
npm ci, then shallow clones (--depth 1) of cap2UI5/cap2UI5 and abap2UI5/abap2UI5, then:It printed
verify-refs: OK — every documented path, class, app id and option resolvesand the VitePress build finished (build complete). The patch applied cleanly on main at ec4c42f, and nothing needed fixing.🤖 Generated with Claude Code
https://claude.ai/code/session_01TRkYvBYut1a1PjFYuUAcqj
Generated by Claude Code