fix: align README header mark with the CLI2API wordmark - #199
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README header icon sat clearly below the CLI2API title.
Cause:
<img … align="middle">. GitHub rewrites the img tostyle="max-width:100%; height:auto; max-height:40px"but preservesalign, which becomes CSSvertical-align: -webkit-baseline-middle(aligns the icon's center to baseline + ½ x-height). At h1 font-size 32px the icon center lands ~11.5px below the text cap center and 20px below the baseline, so the C drops out of line.Fix:
align="top". Measured on the rendered header, the icon center then coincides with the cap center of "CLI2API" (within ~0.5px). Inlinestyle="vertical-align:…"is not an option — GitHub strips it during sanitization;alignsurvives.Applied to both README.md and README_EN.md, plus a bilingual Unreleased changelog bullet.