Conversation
Allow wildcard descriptors to skip SPKs already owned by another keychain when revealing new SPKs. Reject non-wildcard descriptors whose only SPK is already claimed by another keychain with a new `NoDerivableSpk` error variant.
Add regression tests for non-wildcard descriptor rejection, both descriptor insertion orders, wildcard collision handling, and consecutive SPK collisions during SPK revelation.
busayo-OD
requested review from
evanlinjin and
oleonardolima
as code owners
September 27, 2026 18:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2277.
KeychainTxOutIndexdoes not currently handle collisions when a descriptor derives an SPK that is already owned by another keychain.This PR allows wildcard descriptors to skip already-owned SPKs when revealing new scripts and continue to the next available SPK. Non-wildcard descriptors are rejected when their only SPK is already claimed, returning the new
NoDerivableSpkerror variant.Notes to the reviewers
Changelog notice
NoDerivableSpktoInsertDescriptorError.Checklists
All Submissions:
Bugfixes: