Conversation
`populate_with_outpoints` discarded every error returned by `fetch_tx`, so a connection, TLS or timeout failure made `sync` report success without any data for the requested outpoint. A spend of that outpoint was then missed and the UTXO kept being treated as unspent. Skip the outpoint only on `Error::Protocol` and propagate all other errors, matching `populate_with_txids`.
Add a regression test: syncing an outpoint against a server that drops the connection must return an error instead of an empty successful update.
Author
|
@noahjoeris PTAL at this, thanks! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2325 +/- ##
==========================================
+ Coverage 78.84% 78.98% +0.13%
==========================================
Files 31 31
Lines 6060 6062 +2
Branches 288 287 -1
==========================================
+ Hits 4778 4788 +10
+ Misses 1203 1195 -8
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2293
populate_with_outpointsdiscarded everyfetch_txerror, so a connection/TLS/timeout failure madesyncreturnOkwithout data for the outpoint.It now skips only on
Error::Protocoland propagates other errors, matchingpopulate_with_txids.Changelog notice
bdk_electrum:syncnow returns an error instead of silently skipping an outpoint when fetching its transaction fails for a non-protocol reasonChecklists
All Submissions:
Bugfixes: