Skip to content

agents: refine starlark rules and CI merge skills #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 1 commit into from
Sep 28, 2026
Merged

agents: refine starlark rules and CI merge skills #4195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .agents/rules/starlark.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ globs: "*.bzl,BUILD,BUILD.bazel,*.bazel"
* **Why**: This avoids inlining the normalization as part of a complex
expression later in the macro expansion.

## `executable = True` Attributes
* Use `allow_files = True` (with an explanatory comment), not
`allow_single_file = True`, when the attribute may accept `py_binary` (whose
`DefaultInfo.files` has multiple files).

## native.test_suite API
* Don't forward target `tags` to `native.test_suite`; tags on test suites filter
tests instead of setting target execution behavior.
Expand Down
12 changes: 8 additions & 4 deletions .agents/skills/buildkite-get-results/scripts/get_buildkite_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,14 @@ def main():

target = args.pr
if target.isdigit() and len(target) < 10:
print(f"🔍 Inspecting PR #{target} via gh to find Buildkite URL...")
print(
f"🔍 Inspecting PR #{target} via gh to find Buildkite URL...",
file=sys.stderr,
)
target = get_build_url_from_pr(target)

build_id = normalize_build_target(target)
print(f"🚀 Querying Buildkite for build: {build_id}\n")
print(f"🚀 Querying Buildkite for build: {build_id}\n", file=sys.stderr)

# Run bk build view
res = subprocess.run(["bk", "build", "view", build_id])
Expand All @@ -84,11 +87,12 @@ def main():
sys.exit(res.returncode)

if args.download:
print(f"\n📥 Downloading logs for build: {build_id}")
print(f"\n📥 Downloading logs for build: {build_id}", file=sys.stderr)
dl_res = subprocess.run(["bk", "build", "download", build_id])
if dl_res.returncode != 0:
print(
"⚠️ 'bk build download' failed or not supported. Try using 'bk job log <job-id>' for specific jobs."
"⚠️ 'bk build download' failed or not supported. Try using 'bk job log <job-id>' for specific jobs.",
file=sys.stderr,
)


Expand Down
8 changes: 3 additions & 5 deletions .agents/skills/merge-pr/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ When the user asks to merge a pull request (e.g., "merge PR <number>", "merge th
branch.
4. **Queue Shepherding**: Periodically check `gh pr view <pr_number> --json
state,autoMergeRequest,mergeStateStatus,mergeable`. While `state` is
`"OPEN"`, ensure auto-merge is enabled / queued by running `gh pr merge
<pr_number> --auto --squash`. If `autoMergeRequest` is null (e.g., ejected
from the merge queue due to a CI flake in the temporary queue branch),
re-enqueue it for merge by running `gh pr merge <pr_number> --auto --squash`
once checks are retried or green.
`"OPEN"`, if `autoMergeRequest` is `null` and no
`gh-readonly-queue/.*/pr-<pr_number>-` branch exists, re-enqueue with
`gh pr merge <pr_number> --auto --squash` once checks are green.
5. **Completion Notification**: Once `state` becomes `"MERGED"`, send a high-priority message back to the parent conversation.
Loading