fix: key lifecycle state by Click context - #399
Open
codeforester wants to merge 7 commits into
Open
codeforester wants to merge 7 commits into
codeforester wants to merge 7 commits into
Conversation
codeforester
commented
Sep 30, 2026
codeforester
commented
Sep 30, 2026
…lifecycle-state-keyed-by-id-click-context-can-be-misattr
…lifecycle-state-keyed-by-id-click-context-can-be-misattr
This was referenced Oct 2, 2026
…lifecycle-state-keyed-by-id-click-context-can-be-misattr
Contributor
Author
|
Branch maintenance complete.
Left open for review; not merged. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #383
Lifecycle state is keyed by the Click context object, preventing state from being attributed to a different context after object-ID reuse. Regression coverage includes chained context teardown.
Branch maintenance
Refs #426. Targets
main.The branch was refreshed without rewriting history to include
mainata576cc279739eae5e4cfc33ffab2a7fb56de24de. The already-merged calibration patch is absent from this review diff; the original issue patch is preserved.Current-head validation
At
8de1e67df9808ed7d116b8823945daa13496940b: uv lock freshness and baseline, runtime, strict typing, style, and contracts passed locally with all declared extras. Runtime result: 610 passed, 1 warning, 262 subtests passed in 7.79s.Hosted checks: 7/7 required checks passed; 0 checks pending; 0 unsuccessful checks at 2026-10-04T14:19:40.760978+00:00. See the PR Checks tab and #426 for subsequent results.