refactor: Use custom Verify logic - #1931
Open
linkdotnet wants to merge 1 commit into
Open
linkdotnet wants to merge 1 commit into
linkdotnet wants to merge 1 commit into
Conversation
Collaborator
Author
|
This superseeds #1927 given that We can get exempt, see: https://github.com/VerifyTests/Verify/blob/main/docs/maintenance-fee.md#exempt @egil I am fine with both ways, leaning towards removing the dependency |
There was a problem hiding this comment.
🟡 Changes recommended
Generator diagnostics and concurrent snapshot updates are not fully handled.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Refactors generator snapshot verification to use local .verified.cs comparisons instead of Verify.
Changes:
- Adds custom snapshot comparison and update logic.
- Removes Verify initialization and package dependencies.
- Excludes snapshot files from compilation.
File summaries
| File | Changes | Review findings |
|---|---|---|
tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.cs |
Implements custom snapshot verification. | Moderate (2 votes): Assert run.Diagnostics is empty. Critical (1 vote): Serialize or atomically update snapshots to prevent parallel-write races. |
tests/bunit.generators.tests/VerifyInitializer.cs |
Removes obsolete Verify initialization. | None |
tests/bunit.generators.tests/bunit.generators.tests.csproj |
Configures snapshot files and removes Verify references. | None |
Directory.Packages.props |
Removes obsolete Verify package versions. | None |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if (existing == actual) | ||
| continue; | ||
|
|
||
| File.WriteAllText(path, actual, new UTF8Encoding(encoderShouldEmitUTF8Identifier: true)); |
Comment on lines
+25
to
+27
| Assert.Empty(result.Diagnostics); | ||
| var run = Assert.Single(result.Results); | ||
| Assert.Null(run.Exception); |
linkdotnet
force-pushed
the
refactor/custom-verify
branch
from
September 16, 2026 20:15
c950fa4 to
f55e648
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.