Repository navigation
fix(tui): clarify optional LiteLLM custom endpoint - #2549
Conversation
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
This is a focused copy change renaming the LiteLLM endpoint field from "API base URL" to "Custom API base URL" with clarified help text ("optional · leave blank to use the model provider's default endpoint"). Both occurrences in HarnessWizard.tsx and HarnessModelField.tsx (including the harnessModelSummary output label) are updated consistently, and the three affected test files are updated to match — including positive assertions for the new help text so regressions in the clarification will be caught.
A quick grep confirms there are no lingering references to the old "API base URL" label anywhere in src/, and the programmatic identifiers (apiBase, --api-base, schema field) are intentionally left unchanged. No telemetry or test-structure concerns apply to a wording change like this.
LGTM. 🚀
|
Claude Security Review: no high-confidence findings. (run) |
|
CI failing because this is built from a stale branch. The issue is fixed on refactor head |
Description
Clarify the optional LiteLLM endpoint field in the TUI.
API base URLtoCustom API base URLin the project create/add Harness model step, imperative Harness create/update wizard, and project review summary.The field remains optional. Model configuration, endpoint resolution, and request payloads are unchanged: LiteLLM can route directly to the provider encoded in the model ID, while a custom API base overrides that destination.
Related Issue
Addresses the LiteLLM endpoint optionality feedback from the CLI v1 UX review, item 10. No standalone GitHub issue was created for this copy-only follow-up.
Documentation PR
Not applicable. The explanation is included in the TUI. No flags or command descriptions changed, so
command.mdis unchanged.Type of Change
Testing
How have you tested the change?
bun test: 3,975 passed, 0 failed, 6 snapshots. The initial command-sandbox run hit subprocess/loopback restrictions; the full rerun through the TUI-harness runner exited 0.bun run test:e2e, or explained why they are not applicable: AWS E2E tests are not applicable to this copy-only change. No deployment or model invocation was performed.bun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed them (not applicable; no asset changes)Also tested the actual packaged Node CLI through
tui-harness, with PNG screenshots captured and visually inspected:Custom API base URLin review.All flows were stopped before creation confirmation. No AWS resources or project directories were created.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.